Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails with python 2.7.3 #58

Closed
jacobrask opened this issue Dec 27, 2013 · 2 comments
Closed

Installation fails with python 2.7.3 #58

jacobrask opened this issue Dec 27, 2013 · 2 comments

Comments

@jacobrask
Copy link
Collaborator

Critic fails to install with Python 2.7.3 with an unhelpful error message. Upgrading to 2.7.5 solved the issue. 2.7.3 is the default on Ubuntu 12.04, which is the latest LTS release, so I guess supporting it would make sense. Otherwise the version check in the installation script should be updated.

$ python install.py
Traceback (most recent call last):
  File "install.py", line 44, in <module>
    import json
ImportError: No module named json
$ python --version
Python 2.7.3
@mo
Copy link
Collaborator

mo commented Dec 28, 2013

  • the json module was added in python 2.6
  • any python 2.7 version should be supported by critic
  • we have automated testing on ubuntu 12.04.2 and tests are passing

So it "should" definitely work... did you install that python version globally using apt-get or did you use some virtualenv or other kind of tool? If you do "sudo python --version" what version does it say?

@jacobrask
Copy link
Collaborator Author

That's weird. I'm attempting to install Critic in a docker image, it seems like something is wrong in that environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants