Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] - Config file #23

Closed
jenslys opened this issue Dec 9, 2022 · 0 comments · Fixed by #28
Closed

[feat] - Config file #23

jenslys opened this issue Dec 9, 2022 · 0 comments · Fixed by #28
Assignees
Labels
help wanted Extra attention is needed type: documentation Improvements or additions to documentation type: enhancement New feature type: feature request Request for a feature

Comments

@jenslys
Copy link
Owner

jenslys commented Dec 9, 2022

It would be better if all the settings were stored in a separate config file instead of inside the script.

One approach could be using a separate bash file as the config:

config.sh

#!/bin/bash
set -a

hello="Hello World!"
now=$(date)
message="Current time is $now and message is $hello"

set +a

AutoVOD.sh

#!/bin/bash

# Loads the config
source config.sh

echo $message
@jenslys jenslys self-assigned this Dec 9, 2022
@jenslys jenslys added type: documentation Improvements or additions to documentation type: enhancement New feature type: feature request Request for a feature labels Dec 9, 2022
@jenslys jenslys added the help wanted Extra attention is needed label Dec 21, 2022
This was referenced Dec 21, 2022
@jenslys jenslys linked a pull request Dec 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed type: documentation Improvements or additions to documentation type: enhancement New feature type: feature request Request for a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant