Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Nepali (ne) Locale #264

Merged

Conversation

nootanghimire
Copy link
Contributor

Notes:

  • Month names are transliterated. Wikipedia was used as source.
  • Similarly, 'second' and 'minute' are transliterated.

Notes:
  - Month names are transliterated. Wikipedia was used as source.
  - Similarly, second and minute are transliterated.
@nootanghimire
Copy link
Contributor Author

CI Failing because of code in master.

Fix on #265

src/Lang/ne.php Outdated
*/

'ago' => ':time पहिले',
'from_now' => ':time देखी',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

देखि

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger that.

src/Lang/ne.php Outdated
'minute' => ':count मिनेट',
'second' => ':count सेकेण्ड',

'january' => 'जेनवरी',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

जनवरी

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

roger that. my mistake

src/Lang/ne.php Outdated
'november' => 'नोभेम्बर',
'december' => 'डिसेम्बर',

'sunday' => 'आइतवार',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not वार it's बार :)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this should be आईतबार

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure. might have to send a PR to nepalipatro.com.np guys! :)

For refrence: http://pustakalaya.org/view.php?pid=Pustakalaya:2943 (Nepali Dictionary)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ankitpokhrel If you look at the dictionary: http://pustakalaya.org/view.php?pid=Pustakalaya:2943

It says अाइतबार (Page 94, entry: अाइत)

Copy link

@samundra samundra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the changes.

@jenssegers
Copy link
Owner

@nootanghimire Looks like there are some suggestions, could you check them out?

src/Lang/ne.php Outdated
'november' => 'नोभेम्बर',
'december' => 'डिसेम्बर',

'sunday' => 'आइतवार',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually this should be आईतबार

src/Lang/ne.php Outdated
'friday' => 'शुक्रवार',
'saturday' => 'शनिवार',

'sun' => 'आइत',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be आईत

@nootanghimire
Copy link
Contributor Author

@samundra , @ankitpokhrel

Thank you for your reviews. It would be awesome if you could check my changes again.

For reference. Month names were taken from wikipedia: https://ne.wikipedia.org/wiki/%E0%A4%9C%E0%A4%A8%E0%A4%B5%E0%A4%B0%E0%A5%80

And Others were taken from the pustakalaya.org 's online dictionary. http://pustakalaya.org/view.php?pid=Pustakalaya:2943

@jenssegers jenssegers merged commit 88c4b27 into jenssegers:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants