Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing tests #265

Merged
merged 2 commits into from
Dec 5, 2017
Merged

Conversation

nootanghimire
Copy link
Contributor

@nootanghimire nootanghimire commented Nov 30, 2017

Fix the failing translation tests.

For some reason, Date::createFromFormat('m', '02') returns some date in March rather than February.

Fixed by converting that code to Date::createFromFormat('m-d', '02-02');

@samundra
Copy link

@jenssegers This one looks Good :)

@jenssegers
Copy link
Owner

Could you add -01 to all months? Then we will not have this issue for other months as well.

@danhunsaker
Copy link

The reason this is returning March for these tests is that today is the 30th, and February doesn't have 30 days, so you get March 1st or 2nd instead. Months with only 30 days will have the same issue when tests are run on the 31st of any month that has one, without being more specific about the date for all of them, as requested just now.

Just thought I'd illuminate that for others who might stumble across this in, say, a Google search.

@nootanghimire
Copy link
Contributor Author

@jenssegers Will do.

@danhunsaker thanks for the info!

@nootanghimire
Copy link
Contributor Author

nootanghimire commented Dec 5, 2017

@jenssegers looks good?

@jenssegers jenssegers merged commit c878b7b into jenssegers:master Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants