-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Laravel 5.6 support #1428
Laravel 5.6 support #1428
Conversation
RemiCollin
commented
Feb 8, 2018
- Update dependencies
- Fix some method signatures compatible with laravel 5.6
- Remove PHP7.0 job from travis
Merge back master
…stra/TestBench version
Update : have a near working Travis script for 7.1/7.2, but mongodb connection is still failing in the tests :
if anyone has a clue ? |
Please merge :) |
When will this support be available? |
Still waiting for merge) |
Thanks for support @RemiCollin |
Go go go ! |
Waiting for this |
Also waiting - please merge :o) |
Would be nice if someone could merge it ^.^° |
@jenssegers can we get this PR merge to master? |
@jenssegers Any chance of an update on this PR. We just moved to 5.6 and on a tight deadline. Sorry for the nudge. |
@IgnitedCoder why did you hurry up to update? |
@solofeed Better API handling and limiting. More Blade features we need for our project. Better variable casting in models ['field' => 'boolean'] so its better for MySQL inserting/updating, UUID is built in & bootstrap 4. |
@solofeed : also from experience, when you manage a large number of laravel projects, it's more effective to upgrade all your project pool at once, and not leave some projects a few version behind. Anyway, for those wanting to upgrade before this PR is merged, you can use my fork by adding this to composer.json :
|
@IgnitedCoder I also did update, but only my dev env, and this is the last step before pushing things live. |
@bojcheski The client determines what I need to do... and this is a new project so I could not tell them what to do, they already had 5.6 installed. :) |
I just updated signature in vendor and beginning test application on new version) |
@RemiCollin which tag version from your fork includes this patch? |
@arthurkirkosa : I didn't tag it. Just use |
Just for clarity, does dev-master include the 5.6 fixes? |
I've updated to dev-master and composer does alert about Edited: I see, it's not merged yet. |
Yep, not merged... @jenssegers when this merge will happen, please let us know. Sorry to be pushy. :) |
Shameless bump for merge |
Come on! I need this!! |
Merged and tagged! Thanks so much for your help! |
Laravel 5.6 support