Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Laravel 5.6 support #1428

Merged
merged 42 commits into from
Feb 25, 2018
Merged

Laravel 5.6 support #1428

merged 42 commits into from
Feb 25, 2018

Conversation

RemiCollin
Copy link
Contributor

  • Update dependencies
  • Fix some method signatures compatible with laravel 5.6
  • Remove PHP7.0 job from travis

@RemiCollin
Copy link
Contributor Author

Update : have a near working Travis script for 7.1/7.2, but mongodb connection is still failing in the tests :

MongoDB\Driver\Exception\ConnectionTimeoutException: No suitable servers found (`serverSelectionTryOnce` set): [Failed to resolve 'mongodb']

if anyone has a clue ?

@pierrocknroll
Copy link

Please merge :)

@kskrlin
Copy link

kskrlin commented Feb 16, 2018

When will this support be available?

@solofeed
Copy link

Still waiting for merge)
Thank you for PR)

@bsormagec
Copy link

Thanks for support @RemiCollin

@pierrocknroll
Copy link

Go go go !

@tonychuuy
Copy link

Waiting for this

@Oliver-Meyer
Copy link

Also waiting - please merge :o)

@lalawunderland
Copy link

Would be nice if someone could merge it ^.^°

@thilanga
Copy link
Contributor

@jenssegers can we get this PR merge to master?

@IgnitedCoder
Copy link

@jenssegers Any chance of an update on this PR. We just moved to 5.6 and on a tight deadline. Sorry for the nudge.

@solofeed
Copy link

solofeed commented Feb 21, 2018

@IgnitedCoder why did you hurry up to update?
What is so important in 5.6?)

@IgnitedCoder
Copy link

@solofeed Better API handling and limiting. More Blade features we need for our project. Better variable casting in models ['field' => 'boolean'] so its better for MySQL inserting/updating, UUID is built in & bootstrap 4.

@RemiCollin
Copy link
Contributor Author

RemiCollin commented Feb 21, 2018

@solofeed : also from experience, when you manage a large number of laravel projects, it's more effective to upgrade all your project pool at once, and not leave some projects a few version behind.

Anyway, for those wanting to upgrade before this PR is merged, you can use my fork by adding this to composer.json :

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/RemiCollin/laravel-mongodb"
        }
    ],

@bojcheski
Copy link

@IgnitedCoder
Never start a project unless all resources are available.
https://s-media-cache-ak0.pinimg.com/originals/17/bc/49/17bc49b0aa3193b7281f000c5edd3602.jpg

I also did update, but only my dev env, and this is the last step before pushing things live.

@IgnitedCoder
Copy link

@bojcheski The client determines what I need to do... and this is a new project so I could not tell them what to do, they already had 5.6 installed. :)

@solofeed
Copy link

I just updated signature in vendor and beginning test application on new version)
And I am still waiting for update deployer for support Symfony 4

@arthurkirkosa
Copy link

@RemiCollin which tag version from your fork includes this patch?

@RemiCollin
Copy link
Contributor Author

@arthurkirkosa : I didn't tag it. Just use dev-master , should work.

@IgnitedCoder
Copy link

Just for clarity, does dev-master include the 5.6 fixes?

@Surt
Copy link

Surt commented Feb 22, 2018

I've updated to dev-master and composer does alert about
Access level to Jenssegers\Mongodb\Eloquent\Model::getDateFormat() must be public (as in class Illuminate\Database\Eloquent\Model)
during the > @php artisan package:discover

Edited: I see, it's not merged yet.

@IgnitedCoder
Copy link

Yep, not merged... @jenssegers when this merge will happen, please let us know. Sorry to be pushy. :)

@SelimSalihovic
Copy link

:shipit:

@drewhammond
Copy link

Shameless bump for merge

@cherbert
Copy link

Come on! I need this!!

@jenssegers jenssegers merged commit 32974fd into mongodb:master Feb 25, 2018
@jenssegers
Copy link
Contributor

Merged and tagged!

Thanks so much for your help!

mnphpexpert added a commit to mnphpexpert/laravel-mongodb that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.