Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[just-trivia] Manual intervention required to perform subsequent deploys after rollback #4

Open
jeremy21212121 opened this issue Feb 26, 2020 · 0 comments

Comments

@jeremy21212121
Copy link
Owner

On the just-trivia branch, there is a bit of a problem with the rollback process.

The rollback script works by git checkout ${lastKnownGoodCommitHash}. This is all well and good and works, but it results in a detached HEAD state in our local repo on the server.

I thought that this isn't the end of the world, because the repo is never committed to from the application server. So a detached HEAD doesn't really matter, as bad as it sounds.

However, there is a problem. On subsequent pushes to the repo, it won't be able to git pull in the latest version from a detached head state. So the rollback works fine, but the next deploy after that will not succeed.

I've done some some reading and I think I have come up with a simple solution. If I add git checkout master to the front and back end deploy scripts, that should do the trick. It we be redundant but not harmful for a regular deploy, but it will allow the next deploy after a rollback to succeed.

I just need to do some manual testing to make sure git works like I think it does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant