fix: use pretty compiler option for diagnostics

BREAKING CHANGE: betterDiagnostics option has been removed
jeremyben · Jul 26, 2019 · 3c8db99 · 3c8db99
1 parent 3288b56
commit 3c8db99
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 9 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -70,7 +70,7 @@ export function createProgramFromConfig({
  * Compile Typescript files and emit diagnostics if any, throws an error if it fails.
  * @public
  */
-export function emit(program: ts.Program, { basePath, clean, copyOtherToOutDir, betterDiagnostics }: EmitOptions = {}) {
+export function emit(program: ts.Program, { basePath, clean, copyOtherToOutDir }: EmitOptions = {}) {
 	const options = program.getCompilerOptions()
 
 	if (clean) cleanTargets(clean, options, basePath)
@@ -84,7 +84,7 @@ export function emit(program: ts.Program, { basePath, clean, copyOtherToOutDir,
 
 	// https://github.com/dsherret/ts-morph/issues/384
 	const allDiagnostics = ts.getPreEmitDiagnostics(program).concat(diagnostics)
-	logDiagnostics(allDiagnostics, betterDiagnostics)
+	logDiagnostics(allDiagnostics, options.pretty as boolean | undefined)
 
 	if (!options.noEmit && emitSkipped) {
 		console.error(red('Compilation failed'))

diff --git a/src/interfaces.ts b/src/interfaces.ts
@@ -14,11 +14,6 @@ export interface CreateProgramFromConfigOptions extends TsConfig {
 }
 
 export interface EmitOptions {
-	/**
-	 * Format diagnostics with colors and context, instead of single lines.
-	 */
-	betterDiagnostics?: boolean
-
 	/**
 	 * Copy non typescript files and folders to `outDir` path if defined in compiler options.
 	 */

diff --git a/src/log.utils.ts b/src/log.utils.ts
@@ -4,7 +4,7 @@ import ts from 'typescript'
  * Log compiler diagnostics to stderr.
  * @internal
  */
-export function logDiagnostics(diagnostics: ts.Diagnostic[], better = false) {
+export function logDiagnostics(diagnostics: ts.Diagnostic[], pretty = false) {
 	if (!diagnostics.length) return
 
 	const formatHost: ts.FormatDiagnosticsHost = {
@@ -13,7 +13,7 @@ export function logDiagnostics(diagnostics: ts.Diagnostic[], better = false) {
 		getNewLine: () => ts.sys.newLine,
 	}
 
-	const message = better
+	const message = pretty
 		? ts.formatDiagnosticsWithColorAndContext(diagnostics, formatHost)
 		: ts.formatDiagnostics(diagnostics, formatHost)