Skip to content

Commit

Permalink
update CI to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 an…
Browse files Browse the repository at this point in the history
…d Erlang 24 (#436)

* update CI to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 and Erlang 24

* update local development versions to Elixir 1.12.2 and Erlang 24.0.5

* format after Elixir 1.12

* only check format on Elixir 1.12 and above due to a change in the Elixir formatter

* run all CI jobs even if other jobs fail

* remove Elixir 1.9.4 and Erlang 21.3 from CI

* remove mix dialyzer --list-unused-filters

* use setup beam

* move output tests to later on
  • Loading branch information
baseballlover723 committed Sep 9, 2021
1 parent 231d61c commit e8c46d6
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 23 deletions.
30 changes: 15 additions & 15 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,22 +30,26 @@ jobs:
if: ${{ needs.check_duplicate_runs.outputs.should_skip != 'true' }}

strategy:
fail-fast: false
matrix:
elixir:
- '1.9.4'
- '1.10.4'
- '1.11.1'
- '1.11.4'
- '1.12.2'
otp:
- '21.3'
- '22.3'
- '23.0'
- '23.3'
- '24.0'
exclude:
- elixir: '1.10.4'
otp: '24.0'

steps:
- name: Checkout
uses: actions/checkout@v2

- name: Set up Elixir
uses: erlef/setup-elixir@v1
uses: erlef/setup-beam@v1
with:
elixir-version: ${{ matrix.elixir }}
otp-version: ${{ matrix.otp }}
Expand Down Expand Up @@ -81,18 +85,9 @@ jobs:
MIX_ENV: prod

- name: Check source code formatting
if: ${{ matrix.elixir > '1.12.0' }}
run: mix format --check-formatted

- name: Check source code formatting
run: mix dialyzer --list-unused-filters
env:
MIX_ENV: prod

- name: Run output tests
run: mix test
env:
OUTPUT_TESTS: true

- name: Get results in short format
run: mix dialyzer --format short
env:
Expand All @@ -113,6 +108,11 @@ jobs:
env:
MIX_ENV: prod

- name: Run output tests
run: mix test
env:
OUTPUT_TESTS: true

- name: Check examples
run: mix dialyzer --format short --ignore-exit-status
env:
Expand Down
4 changes: 2 additions & 2 deletions .tool-versions
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
elixir 1.11.1
erlang 23.1.1
elixir 1.12.2
erlang 24.0.5
4 changes: 1 addition & 3 deletions lib/dialyxir/warnings/function_application_no_function.ex
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,7 @@ defmodule Dialyxir.Warnings.FunctionApplicationNoFunction do
pretty_op = Erlex.pretty_print(op)
pretty_type = Erlex.pretty_print_type(type)

"Function application will fail, because #{pretty_op} :: #{pretty_type} is not a function of arity #{
arity
}."
"Function application will fail, because #{pretty_op} :: #{pretty_type} is not a function of arity #{arity}."
end

@impl Dialyxir.Warning
Expand Down
4 changes: 1 addition & 3 deletions lib/dialyxir/warnings/opaque_match.ex
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ defmodule Dialyxir.Warnings.OpaqueMatch do
def format_short([_pattern, type | _]) do
pretty_type = Erlex.pretty_print_type(type)

"Attempted to pattern match against the internal structure of an opaque term of type #{
pretty_type
}."
"Attempted to pattern match against the internal structure of an opaque term of type #{pretty_type}."
end

@impl Dialyxir.Warning
Expand Down

0 comments on commit e8c46d6

Please sign in to comment.