update CI to the latest Elixir 1.11 and Erlang 23. Add Elixir 1.12 and Erlang 24 #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baseballlover723
force-pushed
the
pr/add_new_elixir_erlang_ci
branch
2 times, most recently
from
b1b5603
to
f5adc67
Compare
baseballlover723
changed the title
baseballlover723
force-pushed
the
pr/add_new_elixir_erlang_ci
branch
3 times, most recently
from
9a3a75a
to
242c0e8
Compare
|
Hi, thanks for working on this! I think to resolve the errors on OTP 24 we could just remove this entire check from the tests: dialyxir/.github/workflows/test.yml Line 98 in 242c0e8 Also, I would be fine with dropping the 1.9.4 targets entirely since that is 4 releases ago, my original thought was to support the 3 most recent releases anyway. |
|
This has been updated |
baseballlover723
force-pushed
the
pr/add_new_elixir_erlang_ci
branch
5 times, most recently
from
e855b0f
to
ff8a62f
Compare
|
I have no idea why the tests fail now, but most of them did work when I originally pushed it up, https://github.com/jeremyjh/dialyxir/runs/3248958978 |
|
The problem is we're no longer running any dialyzer check before the output_test, so output_test has to build the PLTs etc. Re-ordering the output tests like this will fix it. |
baseballlover723
force-pushed
the
pr/add_new_elixir_erlang_ci
branch
from
8dade54
to
e9cefa8
Compare
jeremyjh
approved these changes
Sep 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also upgrades the local Elixir version to
1.12.2and the Erlang version to24.0.5. This also includes amix formatsince Elixir 1.12 made a backwards incompatible formatting change as well as only running the format check in CI on Elixir 1.12+.This also changes CI to not fail as soon a single job fails, this is needed for now, since CI fails on Erlang 24. This is probably for the better since you can see if CI fails for just a single Elixir / Erlang combination or for all of them.