Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volumes do not get mounted #251

Closed
1 task done
TropicLegend opened this issue Nov 30, 2023 · 5 comments
Closed
1 task done

Volumes do not get mounted #251

TropicLegend opened this issue Nov 30, 2023 · 5 comments
Assignees
Labels
type:enhancement 🚀 New feature or request

Comments

@TropicLegend
Copy link

TropicLegend commented Nov 30, 2023

What happened?

Volumes mentioned in the podOverrides section do not get mounted.
The config I used looks like this:

apiVersion: shulkermc.io/v1alpha1
kind: MinecraftServerFleet
metadata:
  name: ca-server
  namespace: minecraft-network
spec:
  clusterRef:
    name: fl-net
  replicas: 1
  template:
    spec:
      podOverrides:
        resources:
          requests:
            memory: "512Mi"
            cpu: "500m"
          limits:
            memory: "2048Mi"
            cpu: "4000m"
        containers:
          volumeMounts:
            - name: ca-world
              mountPath: /data/world
            - name: ca-world-nether
              mountPath: /data/world_nether
            - name: ca-world-the-end
              mountPath: /data/world_the_end
        volumes:
          -  name: ca-world
             persistentVolumeClaim:
             claimName: ca-world-claim
          -  name: ca-world-nether
             persistentVolumeClaim:
             claimName: ca-world-nether-claim
          -  name: ca-world-the-end
             persistentVolumeClaim:
             claimName: ca-world-the-end-claim
      clusterRef:
        name: fl-net
      tags:
        - lobby
      version:
        channel: Paper
        name: '1.20.2'
      config:
        plugins:
          - url: https://xxxxxxxxxx/s/fCn6TWGQfaHcMnz/download/EssentialsX-2.20.1.jar
          - url: https://xxxxxxxxxx/s/HjdfDzpgGAjRw9r/download/Chunky-1.3.92.jar
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ca-world-claim
  namespace: minecraft-network
spec:
  storageClassName: longhorn
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 50Gi
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ca-world-nether-claim
  namespace: minecraft-network
spec:
  storageClassName: longhorn
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 20Gi
---
apiVersion: v1
kind: PersistentVolumeClaim
metadata:
  name: ca-world-the-end-claim
  namespace: minecraft-network
spec:
  storageClassName: longhorn
  accessModes:
    - ReadWriteOnce
  resources:
    requests:
      storage: 20Gi
---

What components are involved in your issue?

No response

Version

v0.3.0

Kubernetes Version

1.24

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@TropicLegend TropicLegend added flag:triage ♻️ Waiting for triage type:bug 🐛 Something isn't working labels Nov 30, 2023
@jeremylvln
Copy link
Owner

There is a "bug" on the Kubernetes lib I use to generate the CRDs that allows any extra properties to be passed. You while you successfully added a volumeMounts to podOverrides, actually it does nothing as it's not supported. I'll look into adding this feature :)

@jeremylvln jeremylvln added type:enhancement 🚀 New feature or request and removed type:bug 🐛 Something isn't working flag:triage ♻️ Waiting for triage labels Nov 30, 2023
@jeremylvln jeremylvln self-assigned this Nov 30, 2023
@TropicLegend
Copy link
Author

There is a "bug" on the Kubernetes lib I use to generate the CRDs that allows any extra properties to be passed. You while you successfully added a volumeMounts to podOverrides, actually it does nothing as it's not supported. I'll look into adding this feature :)

Thank you very much 👍

@jeremylvln
Copy link
Owner

Let's keep the issue opened, I can add this feature without too much pain :)

@TropicLegend
Copy link
Author

Let's keep the issue opened, I can add this feature without too much pain :)

okay sure 👍

@jeremylvln
Copy link
Owner

This feature was just released, check version 0.5.0 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement 🚀 New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants