Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

climate.heat_transfer() only checks nodes below, prevents horizontal heat transfer between heatable nodes #38

Closed
mel-odious opened this issue Oct 9, 2021 · 1 comment

Comments

@mel-odious
Copy link

While digging through heat transfer stuff I noticed that mods/climate/temperature.lua:381 in climate.heat_transfer() causes heatable nodes to only check the y-coords below them for heat transfer, preventing heat exchange between nodes of the same height. This leads to odd behaviour like a 2-deep, 1-high kiln not heating the rear nodes at all (too far away for the fire to heat via climate.air_temp_source()) whereas a 2-deep, 2-high kiln can heat the rear ones due to having heatable nodes on different y-coords.

Changing the - to a + on that line so it checks a 3x3x3 area matches the logic in climate.air_temp_source() and makes both kilns behave the same so it seems to be a typo.

@jeremyshannon
Copy link
Owner

jeremyshannon commented Oct 9, 2021

Yeah, I guess that is a typo. Fixed by c1fc45b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants