Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sprintf package is deprecated in favor of sprintf-js #120

Closed
hbakhtiyor opened this issue May 14, 2018 · 2 comments
Closed

The sprintf package is deprecated in favor of sprintf-js #120

hbakhtiyor opened this issue May 14, 2018 · 2 comments

Comments

@hbakhtiyor
Copy link

No description provided.

@avallete
Copy link

The title is pretty explicit.

Did we have any update on this issue ?

PS: I mention as an additional intel that the sprintf-js package does not seem to make any breaking change (I've checked all the releases and searched for 'migration guides'). So the update should be straight forward.

Plus, a PR is already waiting to be merged to address this issue: #122

@gjuchault could you please check and merge this PR ?

@avallete avallete mentioned this issue Aug 27, 2018
Closed
@gjuchault
Copy link
Collaborator

@avallete I just saw the PR and merged it thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gjuchault @hbakhtiyor @avallete