Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"doesn't know its parents" error message — need to use gitlab-grit #9

Closed
ruv opened this issue Aug 22, 2017 · 3 comments
Closed

"doesn't know its parents" error message — need to use gitlab-grit #9

ruv opened this issue Aug 22, 2017 · 3 comments

Comments

@ruv
Copy link

ruv commented Aug 22, 2017

This tools doesn't work in default installation (at least on Cygwin). It just produces
#omitting #xxx that doesn't know its parents
for every item.

The command gem install gitlab-grit solves this problem. It installs GitLab fork of Grit version 2.8.1 (for the moment).

Whereas by default Grit 2.5.0 is installed. But it seems that this version is outdated now and Grit is no longer maintained.

In default installation, ref.parents throws NoMethodError on every item in filtering decorated list:

decorated.reject!{|ref|
begin
  ref.parents
  false
rescue NoMethodError
  puts "#omitting #{ref} that doesn't know its parents"
  true
end}

Actually, repo.branches[0].commit.parents throws error:

NoMethodError: undefined method `>>' for "x":String
@jerith666
Copy link
Owner

Seems like a common theme -- see #7 and #8 as well. :)

Shall we just patch README to say to install https://github.com/gitlabhq/grit explicitly?

@ruv
Copy link
Author

ruv commented Aug 28, 2017

Yes, patching README is better than nothing ;)

But why don't just update Gemfile — can we put gem "gitlab-grit" in place of gem "grit"?

@jerith666
Copy link
Owner

Duh, yes -- sorry, I'm not doing much ruby these days. :) PR welcome, otherwise I'll try to get it done myself soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants