Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Publishing the Components classes for better customization #944

Closed
PiousVenom opened this issue Jul 2, 2021 · 1 comment · Fixed by #1297
Closed

[FEATURE] Publishing the Components classes for better customization #944

PiousVenom opened this issue Jul 2, 2021 · 1 comment · Fixed by #1297
Labels
enhancement Improvement related to this package low-priority Low priority issue or feature

Comments

@PiousVenom
Copy link

Describe the solution you'd like

When publishing main views, I'd like src/Components/ to be published as well. The reasoning for this is so that when using the component, I can create my own variables to be passed in to the x-component without having to modify the file in the vendor folder, and risking it being overwritten. Having the ability to fully customize the components by creating new variables to pass in will allow for a better per instance customization.

Example:
I've got a customization on small-box to be able to turn the icon into a link. If I did this on the component that's published, every time I used small-box, the icon is a link. But I may not want that. Nor would I want that link to point to the same location every time. Modifying the src/Components/Widget/SmallBox.php to have a link variable was the only way to make this happen.

@PiousVenom PiousVenom added the enhancement Improvement related to this package label Jul 2, 2021
@PiousVenom PiousVenom changed the title [FEATURE] [FEATURE] Publishing the src/Component for main_views for greater customization Jul 2, 2021
@dfsmania
Copy link
Collaborator

dfsmania commented Jul 2, 2021

Yea, actually we need to create a new asset called components to manage publishing of components, and views related to components should not be published when installing main views. I'm without time currently, and there are other things with priority, but I will get into this on the future...

@dfsmania dfsmania changed the title [FEATURE] Publishing the src/Component for main_views for greater customization [FEATURE] Publishing the Components classes for better customization Jul 3, 2021
@dfsmania dfsmania added the mid-priority Medium priority issue or feature label Jul 18, 2021
@dfsmania dfsmania added low-priority Low priority issue or feature and removed mid-priority Medium priority issue or feature labels Mar 23, 2024
@dfsmania dfsmania linked a pull request Jul 27, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement related to this package low-priority Low priority issue or feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants