Add fwd_bck_parents_max_mut_dist to breakpoint table #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the max of (number of mutations that separate the left parents on the forward and backward passes, number of mutations that separate the right parents on the forward and backward passes), which we agreed could provide the most stringent measure of "HMM consistency".
However, it uses repeated rounds of simplification to calculate the number of mutations between parent nodes, so is slow: it takes
export_recombinant_breakpoints
from 1.5 secs to 12 secs. Personally I'm happy with that, and don't want to spend much time optimising it any more, but @jeromekelleher might have a better method?