Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes "@Object" is used as a type name instead of "Object" or maybe "DartObject" #4

Closed
JeroMiya opened this issue Jul 11, 2020 · 1 comment

Comments

@JeroMiya
Copy link
Owner

For example, see FlutterSDK/Cupertino/Colors.cs in the generated output, you'll see for example this line:

internal static FlutterSDK.Foundation.Diagnostics.DiagnosticsProperty<Color> CreateCupertinoColorProperty(string name,FlutterBinding.UI.Color value,bool showName = true,@Object defaultValue = default(@Object),FlutterSDK.Foundation.Diagnostics.DiagnosticsTreeStyle style = default(FlutterSDK.Foundation.Diagnostics.DiagnosticsTreeStyle),DiagnosticLevel level = default(DiagnosticLevel)){
throw new NotImplementedException();
}

}

Without doing too deep of a dive into the code, I'm going to guess the generator is prefixing @Object because it's generated a class called Object (probably the dart base object class?), in which case it would probably be better to rename this DartObject and add a type name rewriting rule to make this more clear.

@JeroMiya
Copy link
Owner Author

Looks harmless. Closing for now as low-priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant