(GitHub News Feed Filter) Fix for 'Actions' tab|'Wiki' being empty after GitHub site update #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for 'Actions' tab|'Wiki' being empty after GitHub site update (additional re-fix for #124)
darkred
changed the title
Fix for missing some entries in the 'Repositories' tab
jerone
reviewed
May 20, 2018
| @@ -325,7 +325,7 @@ | |||
| Array.prototype.map.call(newsContainer.querySelectorAll(':scope > div > .body'), function(alert) { | |||
| return alert.parentNode; | |||
| }).forEach(function(alert) { | |||
| var alertRepo = alert.querySelector(':scope .flex-items-baseline > div > [data-ga-click*="target:repo"]'); | |||
| var alertRepo = alert.querySelector('[data-ga-click*="target:repo"]'); | |||
There was a problem hiding this comment.
I prefer to use the :scope selector
There was a problem hiding this comment.
But, when using :scope .flex-items-baseline > div > [data-ga-click*="target:repo"]
then there are some entries missing in the 'Repositories' tab, i.e. the global counter might be e.g. 30, but only 27 entries are listed, as I've wrote here.
Do you mean :scope [data-ga-click*="target:repo"] ?
There was a problem hiding this comment.
Do you mean
:scope [data-ga-click*="target:repo"].
Yes (haven't tested it).
There was a problem hiding this comment.
OK, added it. It works ok as well.
Use the :scope selector
jerone
approved these changes
May 20, 2018
|
Thanks. Confirmed working. |
|
🎬 Released as 8.2.1 with another 🐛 fix missing created repo actions. |
|
Thank you for everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for 'Actions' tab|'Wiki' being empty after GitHub site update (additional re-fix for #124)
Note: I changed textContent with innerText, because it contains linebreaks and spaces in HTML (i.e. with textContent).