-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs refactor - key components #4931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
high-level looks good! i like the organization of "concepts" and "modules"
one comment: i noticed all the guides are now under a "Modules" section - to me "Modules" on its own suggests that it's an API reference. could be worth having an API reference section for each section to reduce confusion
maxdepth: 1 | ||
--- | ||
vector_store_guide.ipynb | ||
List Index </guides/primer/index_guide.md> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think you can link to the specific sections with "index_guide.md#list-index" etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm tried it quickly and doesn't seem to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you need to use relative links iirc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes so far. I like the idea of adding a more defined structure to the key sections, makes things easier to navigate
Motivation
retriever
,query engine
,chat engine
are key concepts in llamaindex, but are currently hidden under query interface tabProposed Change
retriever
,query engine
,chat engine
to top levelFuture Work