Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs refactor - key components #4931

Merged
merged 27 commits into from
Jun 4, 2023
Merged

Docs refactor - key components #4931

merged 27 commits into from
Jun 4, 2023

Conversation

Disiok
Copy link
Collaborator

@Disiok Disiok commented Jun 4, 2023

Motivation

  • retriever, query engine, chat engine are key concepts in llamaindex, but are currently hidden under query interface tab
  • we don’t do a good job of showcasing all the modules that we have (e.g. vector index auto retriever)
  • no consistent structure in sections
  • We don’t do a good job of showing the intended usage pattern for each component (we have a big usage pattern section that lumps everything together)

Proposed Change

  • bring retriever, query engine, chat engine to top level
  • make each section have consistent sub-sections
    • concept
    • usage pattern
    • modules
    • (optional) advanced, etc
  • better link between key components (e.g. connector <> index <> retriever <> query engine)
  • Add doc make mapping between retriever mode and retriever class explicit.
Screen Shot 2023-06-03 at 7 01 47 PM

Future Work

  • data agent section

Copy link
Collaborator

@jerryjliu jerryjliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high-level looks good! i like the organization of "concepts" and "modules"

one comment: i noticed all the guides are now under a "Modules" section - to me "Modules" on its own suggests that it's an API reference. could be worth having an API reference section for each section to reduce confusion

docs/how_to/chat_engine/root.md Outdated Show resolved Hide resolved
docs/how_to/retriever/root.md Outdated Show resolved Hide resolved
docs/how_to/query_engine/root.md Outdated Show resolved Hide resolved
docs/how_to/query_engine/usage_pattern.md Outdated Show resolved Hide resolved
docs/how_to/chat_engine/usage_pattern.md Outdated Show resolved Hide resolved
docs/how_to/index/usage_pattern.md Outdated Show resolved Hide resolved
maxdepth: 1
---
vector_store_guide.ipynb
List Index </guides/primer/index_guide.md>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think you can link to the specific sections with "index_guide.md#list-index" etc.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm tried it quickly and doesn't seem to work.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to use relative links iirc

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes so far. I like the idea of adding a more defined structure to the key sections, makes things easier to navigate

docs/guides/primer/query_interface.rst Outdated Show resolved Hide resolved
docs/how_to/chat_engine/usage_pattern.md Show resolved Hide resolved
docs/how_to/index/root.md Show resolved Hide resolved
docs/how_to/query_engine/usage_pattern.md Outdated Show resolved Hide resolved
@Disiok Disiok merged commit 6986d9d into main Jun 4, 2023
@Disiok Disiok deleted the suo/refactor_docs branch June 4, 2023 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants