Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Xcode8.2 in Travis #111

Merged
merged 5 commits into from
Jan 8, 2017
Merged

Use Xcode8.2 in Travis #111

merged 5 commits into from
Jan 8, 2017

Conversation

Liquidsoul
Copy link
Collaborator

@Liquidsoul Liquidsoul commented Jan 3, 2017

Pull request checklist

This fixes issue #110

What's in this pull request?

Simply bumped Xcode version to 8.2 in .travis.yml.

@Liquidsoul
Copy link
Collaborator Author

It appears that the iOS 10.2 simulators are duplicated in the new osx_image xcode8.2:
capture d ecran 2017-01-03 a 09 31 03

I'll try to investigate this when I have some time.

@jessesquires
Copy link
Owner

@Liquidsoul - ha 😄 yep.

We faced the same issue at Instagram/IGListKit#350.

It's a known issue: travis-ci/travis-ci#7031

Our workaround for 10.2 was to use iPad Air 2, since it wasn't duplicated.

@jessesquires
Copy link
Owner

Looks like a few different builds are failing because of simulator issues.

You can see supported sims at:
https://docs.travis-ci.com/user/osx-ci-environment/#Xcode-8.2

Or, we've managed to find a good combination with IGListKit:
https://github.com/Instagram/IGListKit/blob/master/.travis.yml

@codecov-io
Copy link

codecov-io commented Jan 4, 2017

Current coverage is 89.76% (diff: 100%)

Merging #111 into master will not change coverage

@@             master       #111   diff @@
==========================================
  Files            11         11          
  Lines           371        371          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            333        333          
  Misses           38         38          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 9a9b786...c22be4a

Copy link
Owner

@jessesquires jessesquires left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🎉

I added 10.2 to the build matrix.

@jessesquires jessesquires merged commit c35279b into master Jan 8, 2017
@jessesquires jessesquires deleted the issue_110_xcode8.2 branch January 8, 2017 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants