-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Top level function for migrations #66
Top level function for migrations #66
Conversation
} | ||
|
||
return Array(modelDirectoryURLs.flatMap { $0.lastPathComponent }.flatMap { bundle.URLsForResourcesWithExtension("mom", subdirectory: $0) }.flatten()) | ||
.flatMap { NSManagedObjectModel(contentsOfURL: $0) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's breakup this return into multiple steps with descriptive variable names so its easier to read 😄
Thanks @marius-serban ! 😄 🎉 At first glance, this looks great! Before I review in-depth, let's do some re-organization:
|
@marius-serban - Is this ready to go? 😄 |
yup! made those changes Marius
|
🎉 Thanks so much @marius-serban ! I'll be merging soon. here's the plan:
|
@marius-serban - just hand another look at this after merging. And I'm like: Please keep contributing! 😄 |
hey @marius-serban ! i'm going through PRs to add contributors as collaborators on this project. just sent you an invite! 😄 |
Pull request checklist
develop
squashed my commits into 1 commit.This fixes issue #46 .
What's in this pull request?
Added a top level function that performs progressive migrations.
The function is a bit large, it could be broken down but not sure what's your preference @jessesquires .