Top level function for migrations

[marius-serban]

Pull request checklist

• All tests pass. Demo project builds and runs.
• I have resolved any merge conflicts.
• I have rebased on develop squashed my commits into 1 commit.
• I have followed the coding style, and reviewed the contributing guidelines.

This fixes issue #46 .

What's in this pull request?

Added a top level function that performs progressive migrations.
The function is a bit large, it could be broken down but not sure what's your preference @jessesquires .

[jessesquires]

let's breakup this return into multiple steps with descriptive variable names so its easier to read 😄

[jessesquires]

Thanks @marius-serban ! 😄 🎉

At first glance, this looks great! Before I review in-depth, let's do some re-organization:

• Move new code from CoreDataExtensions.swift to a new file, Migrate.swift
• Pull the inner functions out, try to breakup the remaining parts of the function into smaller ones
• All helper functions should be internal and tested if possible/if it makes sense, otherwise let's make them private

[jessesquires]

@marius-serban - Is this ready to go? 😄

[marius-serban]

yup! made those changes

Marius

On 28 Mar 2016, at 04:23, Jesse Squires notifications@github.com wrote:

@marius-serban - Is this ready to go?

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub

[jessesquires]

🎉 Thanks so much @marius-serban !

I'll be merging soon. here's the plan:

1. Release 2.2.1
2. Merge this and release 3.0 with Swift 2.2

[jessesquires]

@marius-serban - just hand another look at this after merging. And I'm like:

Please keep contributing! 😄

[jessesquires]

hey @marius-serban !

i'm going through PRs to add contributors as collaborators on this project. just sent you an invite! 😄