Skip to content

Commit

Permalink
Updates docs and the tsconfig/platformio icons
Browse files Browse the repository at this point in the history
  • Loading branch information
orta committed Jul 18, 2019
1 parent 92a4ae0 commit 38ffc0f
Show file tree
Hide file tree
Showing 13 changed files with 29 additions and 34 deletions.
27 changes: 21 additions & 6 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,14 +118,15 @@ Once you're done working locally and ready to install the production version aga
-----

## Adding File Icons

The process of adding file icons is still a bit complex, but it _has_ been greatly simplified in 1.0. It does however require that you have [node](https://nodejs.org/en/) and [gulp](https://github.com/gulpjs/gulp/blob/master/docs/getting-started.md) installed.

Once you have these, you will need to open a terminal window, navigate to the _seti-ui_ folder and run `npm install` (note you only need to do this once).

Icon Style:

- Use a single color, it will be overwritten when shipped
- Aim for an 18 x 18 bounding box
- Use a single color, the colors will be overwritten to one of the 9 below when shipped
- You want to aim for a frame of 32x32 with the icon centered at and being about 18 x 18 big. There's a sketch file with examples in [this repo](./svgs.sketch).

Once everything is setup, follow these steps any time you want to add a new icon:

Expand All @@ -151,10 +152,24 @@ Once everything is setup, follow these steps any time you want to add a new icon

You will need to do this once for every extension, you want to target. For example, if you want to target both **.sass** and **.scss** extensions, you would add the following:

```
.icon-set('.sass', 'sass', @pink);
.icon-set('.scss', 'sass', @pink);
```
```
.icon-set('.sass', 'sass', @pink);
.icon-set('.scss', 'sass', @pink);
```

3. Run `gulp svg` to minimize the svg files.

## Previewing in VS Code

This is a bit of work, but the steps:

1. Make your changes, and run `gulp icon`
1. Clone VS Code, and make sure that it has the same parent as seti-ui
1. Follow the [VS Code instructions](https://github.com/Microsoft/vscode/wiki/How-to-Contribute#build-and-run) to set up a local dev copy
1. Once you've confirmed that, you need to update the icons. cd to `extensions/theme-seti` and run `node build/update-icon-theme.js`
1. Make sure that inside `extensions/theme-seti/build/update-icon-theme.js` - `let FROM_DISK` is set to true

Then, you can make you SVG changes, re-run `gulp icon`, `node build/update-icon-theme.js` and re-launch your dev copy of VS Code.

## Deploying

Expand Down
Empty file added file-types/platformio.ini
Empty file.
1 change: 1 addition & 0 deletions file-types/tsconfig.json
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
{}
2 changes: 1 addition & 1 deletion icons/pddl.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion icons/plan.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
13 changes: 1 addition & 12 deletions icons/platformio.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
12 changes: 1 addition & 11 deletions icons/tsconfig.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified styles/_fonts/seti/seti.eot
Binary file not shown.
Loading

0 comments on commit 38ffc0f

Please sign in to comment.