Command Palette not showing text 0.121.0

[richrace]

Using Atom 0.121.0. Switching to the Dark UI fixes this.

[timnew]

@richrace I tried to remove the padding. But the text is not in the middle of the box. And 1px padding will place it in the center.

[richrace]

Hmm might depend on the font you use? No padding makes it look just like the fuzzy finder.

My font is: Bitstream Vera Sans Mono

[jesseweed]

Well that's a bummer! You're right, something in the 121 update definitely broke it. I couldn't repro, but as soon as I updated from 120 I hit the same issue. Too bad, it looked much better with the extra padding.

I'll kill padding though until I can figure out what's causing the issue.

[fungilation]

great, 0.2.0 fixed this. But now there are new cosmetic issues, like letter spacing being sub-zero in input text on the Command Palette, and tabs' text are overlapped by the X for closing. For the latter, perhaps simply get rid of the X altogether? cmd/windows-w for closing should be all we need.

[timnew]

@richrace hmm, interesting.
With your inspiration, I think the font size also impact on that, because I found mini-editor is also impacted when I adjust text size with cmd+= and cmd+-.

BTW, I'm using consolas 14px

[izuzak]

Well that's a bummer! You're right, something in the 121 update definitely broke it. I couldn't repro, but as soon as I updated from 120 I hit the same issue. Too bad, it looked much better with the extra padding.
I'll kill padding though until I can figure out what's causing the issue.

cc @nathansobo @benogle on this feedback

[richrace]

@fungilation #27 should fix the tabs. I believe it was related to the file icons in the tab now.

[jesseweed]

@fungilation; confirming #27 fixed the tab issue. Could you explain a little more what you're seeing with "letter spacing being sub-zero in input text on the Command Palette"? I'm not seeing any issues with command palette.

[nathansobo]

Sorry guys. Looks like this was introduced by some styling changes we made in preparation to switch mini editors to the new React-based renderer. Enabling core.useReactMiniEditors eliminated the issue on the previous version of SETI.

[fungilation]

@jesseweed I confirm #27 and latest update fixed everything, including the bunched up lettering. Thanks for the great and fast fixes!

For the new tab icons, is there an option to turn them off? They look nice but not very space saving when I have too many tabs open.

[jesseweed]

@fungilation I haven't found an easy way to do any type of theme level config yet. But, you can add this to your custom stylesheet if you want to kill the tab icons:

.tab-bar .tab .title, .tab-bar .tab.active .title {
  margin-top: 3px;
  &:before { display: none }
}

It's not pretty, but gets the job done.

[jesseweed]

Marking this as resolved.