Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove release message #763

Merged
merged 11 commits into from
Sep 3, 2021

Conversation

connectdotz
Copy link
Collaborator

Removing the release notification since 4.1 has been released over a week so most users should be pretty familiar with the new changes. It seems hard to find the right balance of informative and not-to-be-annoying...

fix #761

@coveralls
Copy link

coveralls commented Aug 29, 2021

Pull Request Test Coverage Report for Build 1180639038

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 94.236%

Totals Coverage Status
Change from base Build 1179606791: -0.02%
Covered Lines: 2454
Relevant Lines: 2552

💛 - Coveralls

@connectdotz
Copy link
Collaborator Author

used this PR to test danger ci setup... tried a few ways to resolve danger CI issue, none has quite worked. Looks like there are 2 options for OSS (see instruction), but neither is ideal... decided to just report error directly from the dangerfile.ts to at least output the actual error in the run-log...

@connectdotz connectdotz requested a review from orta August 30, 2021 02:31
@connectdotz
Copy link
Collaborator Author

@orta you are the danger-js expert, are you ok with our approach?

@connectdotz
Copy link
Collaborator Author

his PR only removed code, the decrease of coverage is purely ratio. Looks like @orta is busy, we will go with the current config until there are better ideas...

@connectdotz connectdotz merged commit a7573b0 into jest-community:master Sep 3, 2021
@connectdotz connectdotz deleted the remove-release-message branch September 3, 2021 23:17
@orta
Copy link
Member

orta commented Sep 4, 2021

Yeah, seems reasonable to me

legend1202 pushed a commit to legend1202/vscode-jest that referenced this pull request Jun 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notification appears every time a new workspace is opened
3 participants