-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
it statements dramatically increase test runtime #56
Comments
I'm trying to find a way to repro this, but it's pretty tricky since I don't have access to a sizeable coffeescript codebase... When I set up a very basic scenario it doesn't seem to cause any observable speed issues when I add another Here's 3 runs of the test with 2 specs: https://gist.github.com/jeffmo/37220916b440d20a465a It would be good if we could narrow this down to where the time is spent. Any chance you could either point me somewhere where I might be able to repro this or try digging in to see if you could narrow it down? |
I'm getting this issue with my repo here: Test file in /app/assets/javascripts/harness/tests/fan-root-test.coffee package.json and node_modules in project root |
Ok, after a little investigation it seems the bulk of the time for each I'm still digging in to what's taking so much time in there, but the gist of the problem here seems to be that every |
I tried moving the |
The easiest solution here would be to identify what the shared state is and just find a way to reset it in the It seems, however, that if you isolate the |
Going to go ahead and close this issue out because I'm not sure there's anything to be done from the Jest side of things |
(Possibly related to facebook/react#812, but I'm guessing a different issue.) |
Hmm alright, thanks for check it out Jeff. Out of curiosity, what do you use to check the runtime of the scripts? |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Every
it
statement, even if the corresponding function is blank, adds roughly 0.2 – 0.5s to the runtime ofnpm test
. Observed by commenting statements in and out.OS X 10.9.3
npm -v 1.4.9
node -v 0.10.28
Tests are in Coffeescript, set up as described in the tutorial
The text was updated successfully, but these errors were encountered: