Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate submit button instead of remember checkbox #116

Open
jesus2099 opened this issue Sep 21, 2015 · 5 comments
Open

Alternate submit button instead of remember checkbox #116

jesus2099 opened this issue Sep 21, 2015 · 5 comments

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Sep 21, 2015

Replace Remember checkbox by adding the below rightmost button (cf. this comment) after each Enter edit MBS button :

( Cancel )   Enter edit   Enter edit (remember edit note) (NEW)

@jesus2099 jesus2099 changed the title ELEPHANT EDITOR ELEPHANT EDITOR. alternate submit button instead of remember checkbox Sep 21, 2015
@jesus2099
Copy link
Owner Author

About the shortcut keys.
We already have Ctrl+Enter to submit (I don’t remember where it comes from, maybe from SUPER TURBO).
We could then have Ctrl+Enter for normal submit and Ctrl+Shift+Enter for remembering note submit (if that works).

@jesus2099 jesus2099 changed the title ELEPHANT EDITOR. alternate submit button instead of remember checkbox Alternate submit button instead of remember checkbox Nov 6, 2015
@jesus2099 jesus2099 added this to the 2016 (late) milestone Jan 7, 2016
@jesus2099 jesus2099 modified the milestones: 2016 (late), 2017 (Ⅵ) Jun 28, 2016
@jesus2099 jesus2099 modified the milestones: 2017, 2018, 2019, 2019* Feb 10, 2017
@jesus2099 jesus2099 added the minor label Feb 1, 2019
@jesus2099 jesus2099 modified the milestones: 2019, 2020 Aug 27, 2020
@jesus2099
Copy link
Owner Author

jesus2099 commented Feb 3, 2021

Or, if we look at how current Remember checkbox works:

  • Edit note to existing edit: default not remember
  • Edit note to new edit: default same as previous new edit

So with buttons:

  • Edit note to existing edit: Ctrl+Enter submits not save button (big borders)
  • Edit note to new edit (or own existing edit?): Ctrl+Enter default save button (big borders)

But I must take care to not being confusing… 🤔

@jesus2099 jesus2099 modified the milestones: 2020, 2021 Aug 21, 2021
@jesus2099
Copy link
Owner Author

No, the behaviour should always be the same, for new or existing edits.

Like I said in 2015 (!):

We could then have Ctrl+Enter for normal submit and Ctrl+Shift+Enter for remembering note submit (if that works).

@jesus2099
Copy link
Owner Author

Also take care in some edit pages (relationships), the previous edit note is not loaded without manual action, by design.

@jesus2099
Copy link
Owner Author

I prefer fixing #723 and #752 at the moment.
And maybe always save but check for duplicate edit notes before saving.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant