Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several edit notes are no longer saved on desktop #752

Closed
6 tasks done
jesus2099 opened this issue Feb 19, 2023 · 2 comments
Closed
6 tasks done

Several edit notes are no longer saved on desktop #752

jesus2099 opened this issue Feb 19, 2023 · 2 comments
Labels
major mb_ELEPHANT-EDITOR regression

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Feb 19, 2023 •
edited

c/w Several edit notes are no longer saved on mobile #723

Since #747, this has broken:

  • Add alias
  • Add disc ID
  • Edit recording
  • Edit release
  • Edit work
  • Merge recordings
@jesus2099 jesus2099 mentioned this issue Feb 22, 2023
Closed
@jesus2099
Copy link
Owner Author

Maybe I should do #97 instead of wasting time here.

@jesus2099 jesus2099 mentioned this issue Mar 30, 2023
Open
7 tasks
@jesus2099 jesus2099 mentioned this issue Jan 3, 2024
Open
@jesus2099 jesus2099 pinned this issue Jan 3, 2024
@jesus2099
Copy link
Owner Author

Check out #116 (comment)

jesus2099 added a commit that referenced this issue Jan 6, 2024
@jesus2099
Fix regression that made ELEPHANT stop saving edit notes #723 #752
d82999d 
Following commit introduced a big regression:

> Only save on edit submits #747 22471b7

Only release editor edit notes were saved, now?! Or what.

And now throw error when ELEPHANT cannot save.
@jesus2099 jesus2099 unpinned this issue Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major mb_ELEPHANT-EDITOR regression
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jesus2099