Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Several edit notes are no longer saved on mobile #723

Closed
11 tasks done
jesus2099 opened this issue Nov 7, 2022 · 12 comments
Closed
11 tasks done

Several edit notes are no longer saved on mobile #723

jesus2099 opened this issue Nov 7, 2022 · 12 comments
Labels
client compatibility major mb_ELEPHANT-EDITOR mobile Currently, mobile means: Android Kiwi Browser react-hydrate new hint: custom mb-hydration event server change

Comments

@jesus2099
Copy link
Owner

jesus2099 commented Nov 7, 2022

c/w Several edit notes are no longer saved on desktop #752


Like for release editor (#679), edit notes are not saved when I edit an URL entity, on mobile (Android 9 Kiwi Browser):

  • Add alias React-hydrate
  • Edit alias
  • Remove artist alias
  • Add release
  • Edit cover art
  • Edit release group
  • Merge recordings
  • Add event art (new page)
  • Edit event art (new page) (strange, Remove event art already works)
  • Remove event art (new page)
  • Reorder event art (new page)
@jesus2099 jesus2099 added client compatibility server change mb_ELEPHANT-EDITOR mobile Currently, mobile means: Android Kiwi Browser labels Nov 7, 2022
@jesus2099
Copy link
Owner Author

The same happened for:

@jesus2099 jesus2099 changed the title URL entity edit edit notes are not longer saved on mobile Several edit notes are no longer saved on mobile Nov 17, 2022
@jesus2099
Copy link
Owner Author

It's specifically on mobile.
I spotted #679 first only on release editor edits and fixed it but is it the case maybe for all (React?) pages, now?

@jesus2099
Copy link
Owner Author

Add alias NG

@jesus2099
Copy link
Owner Author

NG:

  • Edit release group
  • Merge recordings

@jesus2099
Copy link
Owner Author

In the affected edit pages, when I submit, it does not save.
But when I navigate out of the page, it saves.
Which is opposite of what would be expected.

@jesus2099
Copy link
Owner Author

jesus2099 commented Dec 22, 2022

Working Android solution:

notetext.closest("form").addEventListener("submit", saveNote, false);

Needs test on other platforms and need cleanup.

@jesus2099
Copy link
Owner Author

jesus2099 commented Dec 23, 2022

I'm testing a patched 2022.10.28.2 version on my mobile, this week.

@jesus2099
Copy link
Owner Author

Add cover art edit did not trigger mobile edited script.

@jesus2099
Copy link
Owner Author

Maybe I should do #97 instead of wasting time here.

@jesus2099
Copy link
Owner Author

Check out #116 (comment)

jesus2099 added a commit that referenced this issue Jan 6, 2024
Following commit introduced a big regression:

> Only save on edit submits #747 22471b7

Only release editor edit notes were saved, now?! Or what.

And now throw error when ELEPHANT cannot save.
@jesus2099
Copy link
Owner Author

Oh, for alias pages, or if sure to React-hydrate!
On Add release alias, I saw it disappear!

@jesus2099 jesus2099 added the react-hydrate new hint: custom mb-hydration event label Jan 18, 2024
@jesus2099
Copy link
Owner Author

Indeed I get the infamous 2 usual React errors on alias Add/Edit pages:

react-dom.production.min.js:147
Uncaught Error: Minified React error #418; visit https://reactjs.org/docs/error-decoder.html?invariant=418 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
Hydration failed because the initial UI does not match what was rendered on the server.

react-dom.production.min.js:147
Uncaught Error: Minified React error #418; visit https://reactjs.org/docs/error-decoder.html?invariant=418 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
Hydration failed because the initial UI does not match what was rendered on the server.

react-dom.production.min.js:292
Uncaught Error: Minified React error #423; visit https://reactjs.org/docs/error-decoder.html?invariant=423 for the full message or use the non-minified dev environment for full errors and additional helpful warnings.
There was an error while hydrating. Because the error happened outside of a Suspense boundary, the entire root will switch to client rendering.

As seen before:

jesus2099 added a commit that referenced this issue Jul 29, 2024
Not sure if it will be enough to
keep ELEPHANT EDITOR shown in alias pages
that suffer react-hydrate redraw problems
jesus2099 added a commit that referenced this issue Aug 1, 2024
@jesus2099 jesus2099 unpinned this issue Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client compatibility major mb_ELEPHANT-EDITOR mobile Currently, mobile means: Android Kiwi Browser react-hydrate new hint: custom mb-hydration event server change
Projects
None yet
Development

No branches or pull requests

1 participant