Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't save on cancel edit button #747

Closed
jesus2099 opened this issue Jan 12, 2023 · 1 comment
Closed

Don't save on cancel edit button #747

jesus2099 opened this issue Jan 12, 2023 · 1 comment
Labels
bug mb_ELEPHANT-EDITOR

Comments

@jesus2099
Copy link
Owner

It is convenient at times, but this behaviour is counter-intuitive, I believe.
jesus2099 added a commit that referenced this issue Feb 18, 2023
@jesus2099
Only save on edit submits #747
22471b7
@jesus2099 jesus2099 mentioned this issue Feb 19, 2023
Closed
6 tasks
jesus2099 added a commit that referenced this issue Jan 6, 2024
@jesus2099
Fix regression that made ELEPHANT stop saving edit notes #723 #752
d82999d 
Following commit introduced a big regression:

> Only save on edit submits #747 22471b7

Only release editor edit notes were saved, now?! Or what.

And now throw error when ELEPHANT cannot save.
@jesus2099
Copy link
Owner Author

Wow this brought big regression, fixed by d82999d, hopefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug mb_ELEPHANT-EDITOR
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jesus2099