Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The semantic of ProduceBatched in Legacy module should be the same as the one in Kafunk #14

Closed
dongdongcai opened this issue Aug 31, 2018 · 1 comment
Closed

The semantic of ProduceBatched in Legacy module should be the same as the one in Kafunk #14

dongdongcai opened this issue Aug 31, 2018 · 1 comment
Labels
bug Something isn't working v0.9.x Only relevant to 0.9.x bindings in v0 branch

Comments

@dongdongcai
Copy link

The contract of produceBatched in Legacy module is different from the one in Kafunk right now.
May cause some problems for code that relies on this contract.
A potential fix is that to group by partition instead of groupby partition * offset in implementation of ProduceBatched
@vchekan vchekan added the bug Something isn't working label Aug 31, 2018
@bartelink bartelink added the v0.9.x Only relevant to 0.9.x bindings in v0 branch label Mar 23, 2019
@bartelink
Copy link
Collaborator

Closing as this is never going to happen. The FsKafka0 module introduced in 1.4.3 provides an onramp to the practical/viable/maintained API:- FsKafka.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working v0.9.x Only relevant to 0.9.x bindings in v0 branch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vchekan @bartelink @dongdongcai