Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove extraneous Flush ? #81

Open
bartelink opened this issue Nov 9, 2020 · 0 comments
Open

Remove extraneous Flush ? #81

bartelink opened this issue Nov 9, 2020 · 0 comments

Comments

@bartelink
Copy link
Collaborator

bartelink commented Nov 9, 2020 •
edited
Loading

Based on confluentinc/confluent-kafka-dotnet#1449 (comment) it seems to me that the Flush in ProduceAsync can be removed from this impl https://github.com/jet/FsKafka/blob/master/src/FsKafka/FsKafka.fs#L210

More research needed - this is working fine, but maybe the perf can be improved by this...

mhowlett, if you see this, would appreciate any insight you can offer ;)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bartelink