Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reading of files does not handle internationalization #21

Closed
ghost opened this issue Jun 4, 2010 · 5 comments
Closed

Reading of files does not handle internationalization #21

ghost opened this issue Jun 4, 2010 · 5 comments

Comments

@ghost
Copy link

ghost commented Jun 4, 2010

We have files with Japanese characters in them. The StreamReader in FileReader class is not set up to handle international characters.

We've done a build replacing the initialisation with

streamReader = new StreamReader(file, System.Text.Encoding.UTF8, false);

@SergeyMirvoda
Copy link

Same for Russian characters in YUICompressor, but JSMin works fine

@jetheredge
Copy link
Owner

StreamReader should default to UTF8, but I made the change anyways. Can you see if it helps?

@jetheredge
Copy link
Owner

This might also have to do with the YUICompressor. I've had another complaint about that, and I am looking into it.

@ghost
Copy link
Author

ghost commented Jun 7, 2010

That works for me. Thanks

@jetheredge
Copy link
Owner

Great, thanks.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants