Handle null author image #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some servers return null for the image field on the author json. One example is the Rust based https://github.com/colinbankier/realworld-tide. If you create a new profile with that server and this UI before these changes, you'll get a "Deserialize Error". With this patch the author image field changes from a String to an Option<String>, like bio.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some realworld servers return null for the image field on the author json if it hasn't been set. One example is the Rust based realworld-tide server. If you create a new profile with that server and this UI before these changes, you'll get a "Deserialize Error". With this patch the author image field changes from a
Stringto anOption<String>, like bio already is, and the html uses "" for the image source if it is null.