[devbox.Open] drop ensureNixInstalled function call #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
mikeland73
approved these changes
Sep 5, 2023
|
waiting for tests to pass |
github-merge-queue bot
pushed a commit
to jetify-com/devbox-install-action
that referenced
this pull request
Sep 5, 2023
Temporary fix until jetify-com/devbox#1453 is released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem:
Commands like
devbox versionare installing nix.Cause:
By inserting a
debug.PrintStack()one can see thatdevbox.Openis invokedfor
devbox versionfrom a few places. In the latest 0.5.12 release, we addeda call to
ensureNixInstalledindevbox.Open. Hence even though we don't setPreRunE: ensureNixInstalledin the command, the nix install is triggered.
The original motivation for adding this call in
devbox.Openwas thatnixis pretty widely used in theDevboxlibrary, and we should add
ensureNixInstalledas a check.How was it tested?
compiles
will rely on tests to pass