Fix issue causing existing ingresses to not be cleaned up properly #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetstack-bot
added
release-note
munnerz
force-pushed
the
ing-cleanup-unit
branch
from
b5bc173
to
2c433d4
Compare
jetstack-bot
added
size/XXL
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
Signed-off-by: James Munnelly <james.munnelly@jetstack.io>
munnerz
force-pushed
the
ing-cleanup-unit
branch
from
eca8651
to
22f5d8c
Compare
jetstack-bot
added
size/M
|
/cc @kragniz |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kragniz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jetstack-bot
added
the
approved
|
Just came here to report this issue. Looking forward to the new release 馃槃 |
|
Same issue encountered here, looking forward to the next release, thank you! 馃帀 |
|
Same here :( |
alvaroaleman
added a commit
to kubermatic/kubermatic
that referenced
this pull request
Jan 21, 2019
Fixes an issue where a not properly cleaned up Ingress causes the next certificate order to fail cert-manager/cert-manager#831
kubermatic-bot
pushed a commit
to kubermatic/kubermatic
that referenced
this pull request
Jan 21, 2019
Fixes an issue where a not properly cleaned up Ingress causes the next certificate order to fail cert-manager/cert-manager#831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Previously, if an ingress resource did not specify an existing
rulecontaining the domain name we need to solve for (e.g. if only the default backend is configured), we would leave an emptyrule(one with any path configuration) which would consequently fail validation when submitting back to the apiserver.This patch fixes this so we remove empty rules after cleaning up. It also adds a unit test to verify the behaviour. The newly added unit test fails without the second commit applied 馃槃
The actual ingress test fixture for this was taken from聽#828.
Which issue this PR fixes: fixes #828
Release note: