This repository has been archived by the owner on Apr 4, 2023. It is now read-only.
Parameterise ES cluster yaml in tests #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows you to limit the E2E tests that are run by setting a `TEST_PREFIX` environment variable. E.g. TEST_PREFIX=test_cassandra ./hack/e2e.sh To bypass the Elasticsearch tests when I'm running E2E tests manually on my GKE cluster. Part of jetstack#23
|
/test e2e |
|
/test e2e |
wallrj
force-pushed
the
parameterise-es-yaml
branch
from
d9e4c7d
to
25d4624
Compare
|
/test e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: munnerz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows me to override the ES pilot image parameters when I'm running tests manually on GKE.
Using
envsubstas a much lighter weight alternative to using helm chart. Discovered via: kubernetes/kubernetes#23896 (comment)Stacked on #177
Release note: