Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dates before 1970; document escaping issue in dates; avoid unnecessary System.Xml dependency #29

Closed
GoogleCodeExporter opened this issue Mar 16, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

1. Dates before 1970 are negative, but valid; allow them.

2. In a regular expression, "\/" is a synonym for "/".  Jayrock actually can't 
tell the difference between "\/Date()\/" and "/Date()/".  Given how Jayrock is 
structured that's probably OK, but this patch adds a comment to that effect and 
removes the inoperative backslashes from the regex.  Fixing this issue would 
require parser changes to leave markers in the Token when slashes are escaped.

3. As discussed in email, the dependency on System.Xml is mostly avoidable in 
Jayrock.Json, with one exception: DateTime parsing.  From my reading of the 
docs, DateTime.Parse() should handle the cases required.

Original issue reported on code.google.com by rev.chip on 23 Mar 2011 at 3:36

Attachments:

@GoogleCodeExporter
Copy link
Author

3. Fixed[1]

[1] 
http://code.google.com/p/jayrock/source/detail?r=a868d157fb09f092f1fef068e19ff11
d0a40f584

Original comment by azizatif on 18 Apr 2011 at 9:46

  • Changed state: Started
  • Added labels: Component-JSON

@GoogleCodeExporter
Copy link
Author

1. Fixed[1]; permitting dates before 1970

http://code.google.com/p/jayrock/source/detail?r=617e78833422508dd838a065baf6667
cde10aa2d

Original comment by azizatif on 18 Apr 2011 at 10:43

  • Added labels: Milestone-Release1.0

@GoogleCodeExporter
Copy link
Author

2. Fixed[1]

[1] 
http://code.google.com/p/jayrock/source/detail?r=a868d157fb09f092f1fef068e19ff11
d0a40f584

Original comment by azizatif on 18 Apr 2011 at 10:45

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

Issue 33 has been merged into this issue.

Original comment by azizatif on 19 Apr 2011 at 6:46

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant