Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging with knex #51

Open
kibertoad opened this issue Jan 5, 2022 · 3 comments
Open

Merging with knex #51

kibertoad opened this issue Jan 5, 2022 · 3 comments

Comments

@kibertoad
Copy link

Hi! I'm the lead maintainer of knex.js project. Would you be interested in integrating code from your plugin upstream so that it would be included in vanilla knex.js?
@jfgodoy
Copy link
Owner

jfgodoy commented Jan 6, 2022

hi @kibertoad! I'd happy to colaborate.
do you have something in mind about how to do it?

btw, I'm working in a project outside computers, so I'm will answering with some lag

@alexcroox
Copy link

was there an update on this integration?

@kibertoad
Copy link
Author

I don't have time to integrate it myself, but if someone created a PR, I would be happy to review it. We added some of geom support for mysql and pg previously, so this part also might belong there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfgodoy @alexcroox @kibertoad