Skip to content
This repository has been archived by the owner on Dec 18, 2019. It is now read-only.

Dependencies should be listed in setup.py #151

Closed
jpic opened this issue May 7, 2013 · 3 comments
Closed

Dependencies should be listed in setup.py #151

jpic opened this issue May 7, 2013 · 3 comments
Labels
Milestone

Comments

@jpic
Copy link

jpic commented May 7, 2013

I thought I'd get away with this command like for every python module (which I want the dev version or which hasn't been submitted to PyPi yet):

pip install -e git+git://github.com/jflesch/paperwork.git#egg=paperwork

While this did clone the repo and run setup.py fine, it didn't install the dependencies.

I think it is a mistake to rely on packages provided by insert your debian-based distro name here. Instead, it would be better to rely on PyPi, the official Python package index, like all python apps. Not only because it ensures fresher dependencies and dependency version locking, but also because it is cross platform, and supports virtualenv.

To do so, you can use the install_requires kwarg of the setup() function.

@jflesch
Copy link
Member

jflesch commented May 14, 2013

Hm, it seems that there are some dependencies that I can't add to setup.py. For instance, gobject-introspection-thingies (like Gtk, Poppler) are not available on pypi.
However, I can still add the other ones.

@jflesch
Copy link
Member

jflesch commented May 19, 2013

I've removed the dependency list from the README.

It is now in the setup.py.

However, as I said, there are dependencies that can't be checked by setuptools. So I added some custom code in setup.py to look for those dependencies. If some of them are not available, it will tell the user what command to run to install them (on Fedora, Ubuntu, Debian and Gentoo for now).

I don't think I can do any better.

@jflesch jflesch closed this as completed May 19, 2013
@jflesch
Copy link
Member

jflesch commented May 19, 2013

Done in:
6a63023
7953656
ad9f320
8ac698c
d3da0a8
3aa0314

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants