Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement for recursive scan detection #617

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Improvement for recursive scan detection #617

merged 5 commits into from
Jan 16, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 11, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR improves the way we detect whether or not to apply a recursive scan in Frogbot
Depends on changes in: jfrog/jfrog-cli-core#1105

@eranturgeman eranturgeman added safe to test Approve running integration tests on a pull request improvement Automatically generated release notes labels Jan 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 11, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 11, 2024
sverdlov93
sverdlov93 reviewed Jan 11, 2024
View reviewed changes
utils/params.go Outdated Show resolved Hide resolved
utils/params.go Outdated Show resolved Hide resolved
@sverdlov93
Copy link
Contributor

I subject also adding somewhere on the readme that our default way of scan is recursive, unless the user provided working dirs (also on CLI audit readme)
@eranturgeman

@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 14, 2024
@eranturgeman eranturgeman added the safe to test Approve running integration tests on a pull request label Jan 16, 2024
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman merged commit 220b7ad into jfrog:dev Jan 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eranturgeman @sverdlov93