Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve recursive scan detection #1105

Merged
merged 4 commits into from
Jan 16, 2024
Merged

Improve recursive scan detection #1105

merged 4 commits into from
Jan 16, 2024

Conversation

eranturgeman
Copy link
Contributor

@eranturgeman eranturgeman commented Jan 11, 2024 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • All static analysis checks passed.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

This PR improves the detection of whether or not to apply a recursive scan

@eranturgeman eranturgeman added the improvement Automatically generated release notes label Jan 11, 2024
@eranturgeman eranturgeman mentioned this pull request Jan 11, 2024
Merged
3 tasks
sverdlov93
sverdlov93 reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@sverdlov93 sverdlov93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should also add a test to CLI to check that this functionality works

xray/commands/audit/audit.go Outdated Show resolved Hide resolved
xray/commands/audit/audit.go Outdated Show resolved Hide resolved
xray/commands/audit/scarunner.go Outdated Show resolved Hide resolved
xray/commands/audit/scarunner.go Outdated Show resolved Hide resolved
xray/commands/audit/audit.go Outdated Show resolved Hide resolved
xray/commands/audit/scarunner_test.go Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

👍 Frogbot scanned this pull request and found that it did not add vulnerable dependencies.

@eranturgeman eranturgeman mentioned this pull request Jan 14, 2024
Merged
4 tasks
@eranturgeman eranturgeman merged commit 2653d88 into jfrog:dev Jan 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sverdlov93 sverdlov93 sverdlov93 left review comments

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eranturgeman @sverdlov93