Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix caching docker build #16

Open
jgarzik opened this issue Oct 7, 2019 · 2 comments
Open

Fix caching docker build #16

jgarzik opened this issue Oct 7, 2019 · 2 comments
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@jgarzik
Copy link
Owner

jgarzik commented Oct 7, 2019

For some as-yet-not-investigated reason, the double-build technique that enables docker caching, currently commented-out in the Dockerfile, causes the docker build to fail thusly:

   Compiling actix-files v0.1.4
   Compiling kvdbd v0.3.1 (/usr/src/kvdbd)
error: couldn't read src/kvdb-pb.rs: No such file or directory (os error 2)

error: aborting due to previous error

error: Could not compile `kvdbd`.
warning: build failed, waiting for other jobs to finish...
error: couldn't read src/tester.rs: No such file or directory (os error 2)

error: aborting due to previous error

error: Could not compile `kvdbd`.
warning: build failed, waiting for other jobs to finish...
error: build failed
The command '/bin/sh -c cargo build --release' returned a non-zero code: 101
@jgarzik jgarzik added the bug Something isn't working label Oct 7, 2019
@jgarzik jgarzik added this to the 2.0.0 milestone Oct 7, 2019
@jgarzik jgarzik added the help wanted Extra attention is needed label Oct 18, 2019
@jakeschurch
Copy link

I tried looking into this - for this part specifically, I believe you need to also mock src/testers.rs and src/kvdb-pb.rs with a main function since you have 3 bins in your Cargo.toml/

However after this I was running into an issue where protoc --version could not be executed (from the build.rs file) and was not able to make any progress on that.

@jgarzik
Copy link
Owner Author

jgarzik commented Nov 21, 2019

@jakeschurch Thanks for advancing the issue. I think you indeed found the bug (multi-bin related).

The protoc issue is unrelated; apparently it wants updating to 3.10.x or so.

@jgarzik jgarzik modified the milestones: 2.0.0, Future Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants