Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for add_title, add_units, add_precursors #32

Closed
bpbond opened this issue Feb 25, 2017 · 2 comments
Closed

Add tests for add_title, add_units, add_precursors #32

bpbond opened this issue Feb 25, 2017 · 2 comments

Comments

@bpbond
Copy link
Member

bpbond commented Feb 25, 2017

Also want to have checks that chunks have provided required documentation on their objects.
ALSO want to check that their precursors are in fact one of their inputs!
Put this logic in return_data or the driver?

  # Check that the chunk has provided required data for all objects
  for(at in c(ATTR_TITLE, ATTR_UNITS, ATTR_COMMENTS, ATTR_PRECURSORS)) {
    for(obj in names(dots)) {
       if(is.null(attr(dots[[obj]], at))) {
         warning("No '", at, "' attached to ", obj)
       }
     }
   }
@bpbond
Copy link
Member Author

bpbond commented Feb 25, 2017

See #27

@bpbond
Copy link
Member Author

bpbond commented Feb 27, 2017

Implemented in 3a11df8.

@bpbond bpbond closed this as completed Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant