Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roborock - Error, Cleaned area , Mop states + charging/docked state #173

Closed
shaarkys opened this issue Mar 10, 2023 · 13 comments
Closed

Roborock - Error, Cleaned area , Mop states + charging/docked state #173

shaarkys opened this issue Mar 10, 2023 · 13 comments
Labels

Comments

@shaarkys
Copy link

Do you think you can include also Error, Cleaned area , Mop ? I can create eventually feature request - also make sense if it's easy to implement, not sure how the integration works and if my inputs from iOBroker actually have added value....

#165 (comment) (Io.Broker screenshot)

@shaarkys
Copy link
Author

https://github.com/Maxmudjon/com.maxmudjon.mihomey/blob/master/drivers/mi_rockrobo_vacuum_s5/device.js

this.vacuumStates = {
1: "Starting",
2: "Charger disconnected",
3: "Idle",
4: "Remote control active",
5: "Cleaning",
6: "Returning home",
7: "Manual mode",
8: "Charging",
9: "Charging problem",
10: "Paused",
11: "Spot cleaning",
12: "Error",
13: "Shutting down",
14: "Updating",
15: "Docking",
16: "Going to target",
17: "Zoned cleaning",
};
this.vacuumErrorCodes = {
0: "No error",
1: "Laser distance sensor error",
2: "Collision sensor error",
3: "Wheels on top of void, move robot",
4: "Clean hovering sensors, move robot",
5: "Clean main brush",
6: "Clean side brush",
7: "Main wheel stuck?",
8: "Device stuck, clean area",
9: "Dust collector missing",
10: "Clean filter",
11: "Stuck in magnetic barrier",
12: "Low battery",
13: "Charging fault",
14: "Battery fault",
15: "Wall sensors dirty, wipe them",
16: "Place me on flat surface",
17: "Side brushes problem, reboot me",
18: "Suction fan problem",
19: "Unpowered charging station",
};

        if (result[0]["state"] == 5) {
          this.updateCapabilityValue("vacuumcleaner_state", "cleaning");
        } else if (result[0]["state"] == 11) {
          this.updateCapabilityValue("vacuumcleaner_state", "spot_cleaning");
        } else if (result[0]["state"] == 15) {
          this.updateCapabilityValue("vacuumcleaner_state", "docked");
        } else if (result[0]["state"] == 8) {
          this.updateCapabilityValue("vacuumcleaner_state", "charging");
        } else if (result[0]["state"] == 10) {
          this.updateCapabilityValue("vacuumcleaner_state", "stopped");

@shaarkys shaarkys changed the title Roborock - Error, Cleaned area , Mop states Roborock - Error, Cleaned area , Mop states + charging state Mar 10, 2023
@shaarkys shaarkys changed the title Roborock - Error, Cleaned area , Mop states + charging state Roborock - Error, Cleaned area , Mop states + charging/docked state Mar 10, 2023
@jghaanstra
Copy link
Owner

I'm aware of this but I fail to see how it relates to this feature request.

@shaarkys
Copy link
Author

It's partially only - Errors... and the Charging/Docked states.

@jghaanstra
Copy link
Owner

  • Errorcode : implemented with the next release (3.1.9)
  • Mop intensity: implemented as custom capability under advanced driver if device supports it
  • Charging / Docked differentiation: implemented with the last release.

Please close this issue after successful testing or elaborate on what more is requested.

@shaarkys
Copy link
Author

shaarkys commented Mar 12, 2023

Thank you, looks great. I just tested latest version, it's almost perfect, just few small things :

  • error code seems to be updated, tested two events - unfortunately there is no trigger for error state nor any variable error would be stored in, can you please add them ?
  • when error reported, robot shall update it's state to STOPPED I guess (looks it remains in last command)
  • could be total cleaned area m2 and clean count populated into variable ? (can be used to track down trash bin full events)

Can't test MOP intensity as S6 do not support it, so hopefully someone else reports in case of problems (I meant slightly different functionality (just mop installed YES/NO but some others use Water BOX etc. - but it's really minor, what you have implemented above is much more important).

Diag if needed : cdf42784-94c9-4001-a442-f17566f5a8c4

@jghaanstra
Copy link
Owner

error code seems to be updated, tested two events - unfortunately there is no trigger for error state nor any variable error would be stored in, can you please add them ?

The Status has changed trigger card will be trigger upon error including the error as description as status token.

when error reported, robot shall update it's state to STOPPED I guess (looks it remains in last command)

Will add that.

could be total cleaned area m2 and clean count populated into variable ? (can be used to track down trash bin full events)

Not for now, I really want to focus on upgrading existing functionality. I'm already adding too much new stuff which I never promised to do.

@shaarkys
Copy link
Author

Not for now, I really want to focus on upgrading existing functionality. I'm already adding too much new stuff which I never promised to do.

I understand, I just thought it might be last easy step to add...nevermind, will have to continue relying on ioBroker integration then, thank you.

@jghaanstra
Copy link
Owner

Added with the latest release (3.1.11). Please confirm and close the ticket when OK.

@shaarkys
Copy link
Author

I apologize if I missed anything but I don't see anywhere cleaned area m2, clean count - do I have to re-add my Roborock devices ? Thank you.

obrazek
obrazek

@jghaanstra
Copy link
Owner

These are global tokens, look under the app, not under the device.

@shaarkys
Copy link
Author

Thank you. First I didn't understand what you mean but found it... so in case of more devices, those values always represent the last which was updating it? Please also note I got error now when trying to start cleaning - error Missing capability listener - diag. f8308ccc-f976-4d54-af40-a8b0cc5fad39

obrazek

@jghaanstra
Copy link
Owner

I'll add the name of the device they belong to. The issue is also related to users with more than one vacuum cleaner paired. Will be fixed in the next release (3.1.12).

@shaarkys
Copy link
Author

All seems to be fine, including global tokens per device - great job, thank you so much, I can now get rid of IoBroker for Roborocks and you FULLY replaced now for me the original Roborock app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants