Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax documenttation on thematic breaks contridicted by test #46

Closed
leroycep opened this issue Aug 12, 2022 · 1 comment
Closed

Syntax documenttation on thematic breaks contridicted by test #46

leroycep opened this issue Aug 12, 2022 · 1 comment

Comments

@leroycep
Copy link

The syntax documentation for thematic breaks says:

A line containing four or more * or - characters, and nothing else (except spaces or tabs) is treated is a thematic break (<hr> in HTML).

I interpreted this to mean four characters, excluding spaces.

However the first test in the thematic breaks file contradicts this:

```
hello
- - -
there
.
<p>hello</p>
<hr>
<p>there</p>
```

Is the count supposed to include spaces, or should it only include * and - characters?

@jgm
Copy link
Owner

jgm commented Aug 13, 2022

I've updated the docs to say "three or more," which is what the code says.

A case could be made for requiring four or more -- the case would be that --- is already an em-dash. However, that problem could also be solved by just requiring * characters for thematic breaks (as someone has already suggested on another issue).

@jgm jgm closed this as completed in 95bfc01 Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants