Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible problem with bot edits causing breakage of darcs' hash assumption #51

Closed
jgm opened this issue Jul 9, 2011 · 2 comments
Closed
Assignees

Comments

@jgm
Copy link
Owner

jgm commented Jul 9, 2011

From my reading of http://wiki.darcs.net/DarcsWiki/NamedPatch it seems that
darcs considers two patches to be the "same" if the have the same log
message, timestamp, and author.

So, on a gitit wiki with a darcs backend, a bot could theoretically make
two edits in quick succession, within less than a second, with the same log
message, and thus create two patches that darcs would incorrectly consider
equal.

Google Code Info:
Issue #: 27
Author: gree...@gmail.com
Created On: 2009-02-12T15:21:45.000Z
Closed On: 2009-02-13T03:11:29.000Z

@ghost ghost assigned jgm Jul 9, 2011
@jgm
Copy link
Owner Author

jgm commented Jul 9, 2011

I asked in #darcs about this and it turns out that darcs >2.1 adds a random noise
line to every patch log - so this shouldn't ever happen. Please close this issue.

Google Code Info:
Author: gree...@gmail.com
Created On: 2009-02-12T15:51:22.000Z

@jgm jgm closed this as completed Jul 9, 2011
@jgm
Copy link
Owner Author

jgm commented Jul 9, 2011

Google Code Info:
Author: fiddloso...@gmail.com
Created On: 2009-02-13T03:11:29.000Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant