Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

time-1.5 compatibility #29

Closed
wants to merge 1 commit into from
Closed

Conversation

bgamari
Copy link

@bgamari bgamari commented Feb 6, 2015

The time package now exposes its own TimeLocale.

The `time` package now exposes its own `TimeLocale`.
@nikomi
Copy link

nikomi commented Feb 11, 2015

Nice fix!

The upper limit on time needs to be removed in the cabal file though.

@bgamari
Copy link
Author

bgamari commented Feb 11, 2015

@nikomi as far as I can tell there are not bounds on time (which is itself a bit problematic). Are you seeing something I'm not?

@nikomi
Copy link

nikomi commented Feb 11, 2015

In hslogger.cabal of version 1.2.6 on Hackage I see the following:

if flag(small_base)
    build-depends: base >= 4 && < 5, containers, directory, process,
        time < 1.5, old-locale
else

I believe this < 1.5 needs to be removed when applying this pull request. The else part describes dependencies for base < 3 - I don't think that path needs to be changed.

Since the pull request commit does not seem to mention an update to hslogger.cabal I thought I'd better mention it.

@bgamari
Copy link
Author

bgamari commented Feb 11, 2015

@nikomi ahh, right. Unfortunately the latest Hackage release hasn't been pushed to the repository so there's really no way to fix this at the moment.

@nikomi
Copy link

nikomi commented Feb 11, 2015

No prob - it should just be remembered when the pull request is merged.

@bgamari bgamari closed this Feb 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants