-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is there a way to use pyhist with version numbers like "1.0.0b1" for pre-releases? #4
Comments
Thanks a lot for your interest in the project, @bastienboutonnet! Yes, the support of pre-releases and specific tags are in the support plan. This is just the very first release. Release as Pre-Release
Release as specific version
If you want, you are completely free to contribute. Let's keep talking |
Awesome at least if it's on the radar means you're not against it hehe Yep I'd love to contribute. From what I was able to see is that at the moment the functions that parse the versions are pretty strict. Would it make sense to allow them first to parse string like stuff? What do you see might be the best way to have a stab at it. Also am I right that |
Sorry for my late response. Yes, indeed the I haven't seen the output error when you execute def get_current_version_parts(self) -> Tuple[int, int, int]:
version_str = self._get_version_str()
return [int(version_part) for version_part in version_str.split(".")] To support "custom" versions, we would need to change a couple of things:
|
No worries at all @jgoodman8 The error output, which I don't have handy right now, was indeed coming from this part of the stack I believe, at least it looks familiar. It seems pretty "straighforward". If you're into it I could try and find some time to have a go at it some day (probably next weekend or so) |
It would be great @bastienboutonnet |
No woeries! A quick one. Can you rephrase or elaborate the first todo/bullet point you made in your last message? I think the other 3 are clear to me but not sure about the first. |
Yep, I think it's the trickiest. |
@jgoodman8 sure no worries and no rush! I can take care of the rest after :) |
I was looking for a way to generate nice changelogs without sweating and since I use conventional commits this looks like a good package.
Howwver, I'm not using absolutely strict semver whereby I have pre-release info like
1.0.1a1
etc.Doing
pyhist init
crashed because of the non int.I was wondering if there was any plan/willingness to support this kind of versioning?
If so, I might be totally happy to help contribute. Lemme know!
The text was updated successfully, but these errors were encountered: