Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug introduced in 24.6.1: Font lists with fonts requiring quotes such as "Helvetica Neue" are not supported any more #4560

Closed
2 tasks done
rene-leanix opened this issue Jul 22, 2024 · 1 comment

Comments

@rene-leanix
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for a feature request that matches the one I want to file, without success.

You must agree to search and the code of conduct. You must fill in this entire template. If you delete part/all or miss parts out your issue will be closed.

If you are technical, you should reporting bugs along the lines of https://marker.io/blog/how-to-write-bug-report. If you are not technical, we will make allowances, please try to make an effort to understand the process.

Describe the bug
The HTML escaping introduced here for fontName leads to invalid font-family styles for font lists with some quoted elements.

To Reproduce
Steps to reproduce the behavior:

  1. For a shape with a label, set the custom font to: "Helvetica Neue", Helvetica
  2. The shape is rendered with the browser's fall-back, e.g. serif.

image
image

Expected behavior
font-family style is correct and specified font is rendered.

image
image

Screenshots
See above.

draw.io version (In the Help->About menu of the draw.io editor):

  • draw.io version 24.7.1

I tested the problem in incognito/private mode with all browser extensions switched off, write "yes" below:

  • Yes
@davidjgraph
Copy link
Collaborator

24.7.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants