Added indeterminate progress bar, fixes #372 #2145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an improvement, fixing #372. It allows the use of indeterminate progress bars, as seen below:
You can do this by skipping the
valueattribute in yourprogresstag.Proposed solution
It's an adaptation to @scottwernervt's code on the issue #372. Many other big frameworks support indeterminate progress bar styles, so why shouldn't Bulma? 😄
Testing Done
Tested on Chrome and Firefox on Linux, their latest versions. I consider it should work on the recent versions of any major browser, as this solution was proposed a year ago.