-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When dragging a card over a column, the enclosing rectangle sometimes doesn't show or shows very briefly and disappears #3
Comments
Hey @raja-baz , Thanks for taking the time to give some input and feedback, its really appreciated. So just for me to be clear, are we talking about the dashed outline when dragging a card over a column? This is handled by a drag event and checking whether it is over a column then the class 'over' is added to the column. So maybe it is the case that this isn't firing for some reason. I will try and look into it, I have a lot of things to get working on and hoping I am going to get some time to work on them very soon. Thanks again for this! |
Yes, I'm talking about the dashed outline. If I get the time I might look into the code and send you a pull request over the next couple of days. Keep up the good work mate :) |
Thought about posting this as a comment there, but then I thought this way would be less work for you. By the way, let me just say that I was really impressed with your handling of criticism/feedback on HN :) |
Ha, yeah I certainly need to go through that and make a list of the different things people suggested. Thanks for that! It means a lot when people say that kinda thing to me. tyto was something I built to help myself out but when I showed it to some people they mentioned that they would also find it useful and with that in mind I thought why not try and polish it up a little bit in terms of making it easy for people to change themselves making it the tool you take over ha. I'm just real happy that people have shown interest in it and given as much feedback as they have, that's my angle on it. Posting it to HN I was really expecting it to get maybe a couple of hits on github and it fall off the new page, not to end up at the top of the front page ha. I posted it expecting no comments but as it's not a finished thing and I am no UX master I'm really happy with the amount of comments it received and I really appreciate when people say "well how about doing it like this.." or the likes because it makes me see things a little differently in a sense. I'm still trying to get it shared a little and gain a little more feedback and insight because it all helps. The thing is as people have shown some interest, I'd like people to use it if they feel it will help them so moving it towards being community driven will help with this and I think it would be really cool to be able to use a tool and think to yourself "i helped out making this". I really do appreciate the amount of feedback it's had and the fact that people are willing to help out or share their ideas etc. is really awesome to me. Thanks again @raja-baz !! |
So I looked at this again today, the problem is that a "dragleave" is fired when the cursor enters one of the column's children and that makes the border around the drop area disappear. This SO discussion is relevant: http://stackoverflow.com/questions/7110353/html5-dragleave-fired-when-hovering-a-child-element I have no obvious solution yet. |
Hmm that's strange. Well I think maybe that there is some logic or maybe even the possibility of adding a drag event listener to the child that just adds the class to the parent. I thought that this was already how it had been implemented though. We could try using a draggable implementation. I did write a vanilla js one but I had an issue when dragging it outside of columns and it just changing size horribly. I think what I am going to try and do today is sit down and create an issue list and then I'm thinking of maybe creating several feature and issue branches. I think I'll create a branch of this version too and leave it as is. What are your thoughts on this? I'm thinking then maybe can have a branch for this issue and maybe one for trying out a draggable implementation. Thanks again for your input and help, it's really appreciated! :) P.s sorry for the delay on my end with things but typically around this time of year I've fallen a little under the weather |
I think this will be solved by solving issue #9. When changing over to portlets, this should sort itself out hopefully. |
It's all in the title, happened on both Firefox nightly and chrome(latest stable version, 31 I think) both on OSX mavericks.
I notice that it happens more(or only, not sure) when the column already has cards in it while you're dragging.
The text was updated successfully, but these errors were encountered: